Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find replacement for sodiumoxide crate (not urgent) #79

Open
bnewbold opened this issue Oct 9, 2022 · 2 comments
Open

Find replacement for sodiumoxide crate (not urgent) #79

bnewbold opened this issue Oct 9, 2022 · 2 comments

Comments

@bnewbold
Copy link
Member

bnewbold commented Oct 9, 2022

The sodiumoxide crate is marked as "archived" and will receive only security updates going forward: https://github.com/sodiumoxide/sodiumoxide

On the one hand, it should receive security updates, is stable, and is working fine for our needs, so there is no urgent need to update.

On the other hand, it would be good to be using something maintained going forward. If possible and secure, it would also be nice to use a pure-Rust library to reduce system dependencies and compile time, though it is nice to rely on the broadly-used known quantity that is libsodium (the underlying C library).

@dunxen
Copy link
Member

dunxen commented Oct 11, 2022

Yeah, I think we're fine with sodiumoxide for now. We can ignore any "unmaintained" advisories we get for it currently.

It would be great to have a robust and audited pure Rust replacement! I don't see one thing we could easily swap it out for that offers the secretbox algo stuff and the HMAC stuff together. We can keep this issue open for suggestions.

@bnewbold
Copy link
Member Author

Here is an additional advisory I found: https://rustsec.org/advisories/RUSTSEC-2021-0137

I think the combination of hmac, sha256, and xsalsa20poly1305 crates would work together. Probably worth verifying the impact on build size.

(not proposing we make any changes before the next release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants