Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module uses old part of the mParticle Android SDK #75

Open
ngregory-rbi opened this issue Jul 25, 2022 · 4 comments
Open

Module uses old part of the mParticle Android SDK #75

ngregory-rbi opened this issue Jul 25, 2022 · 4 comments

Comments

@ngregory-rbi
Copy link
Contributor

Last week, version 5.43.0 of the mParticle Android SDK was released. This commit changed the type of the first parameter of getUserAttributes from UserAttributeListener to UserAttributeType. This native module calls that method but passes in an object of the old type (here). Given that the build.gradle file simply pulls in the latest version, this breaks the module itself. It should be updated to use the new SDK, or be limited to using the version before.
@ngregory-rbi
Copy link
Contributor Author

cc @willpassidomo

@ngregory-rbi
Copy link
Contributor Author

Appears to have been fixed by this commit: a8ed2cf#diff-87c2fbaecb5abf01a845cb4c3af6ca78add2676dd28f6b336403b4c2b979018cL36

@ngregory-rbi
Copy link
Contributor Author

ngregory-rbi commented Aug 4, 2022 •
edited
Loading

Ok that's just a test file that was changed, not the actual source. The source still needs to change.

@ngregory-rbi ngregory-rbi reopened this Aug 4, 2022
@mchuangatmp
Copy link
Contributor

@ngregory-rbi we are working on a fix right now. Thanks for bringing this to our attention, sorry this slipped our radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mchuangatmp @ngregory-rbi