Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mod: empty taskbar click] update 1.7 no longer opens start menu if start button is hidden #21

Open
donsingh opened this issue Nov 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@donsingh
Copy link

donsingh commented Nov 25, 2024

@m1lhaus first of all, thank you for the very quick update on getting the multi monitor support i requested here #19

I just want to report a bug that i noticed was working on 1.5 and has broken since the implementation of 1.7.

This bug relates to another mod, Windows 11 Taskbar Styler where it allows us to hide the start menu. In their details, they describe a quick way to hide the start button:

Hide the start button
Target: Taskbar.ExperienceToggleButton#LaunchListButton[AutomationProperties.AutomationId=StartButton]
Style: Visibility=Collapsed

If i implement this, clicking on the taskbar with your mod to "Open start menu" no longer works. I'm guessing your recent update requires the start button to still function. The current update is fine with me as i don't mind having it shown but I can see how having it hidden provides a cleaner look since the whole taskbar is not the start menu trigger.

In the old version (1.5), hiding the start button did not interfere with the clicking of the empty taskbar space to trigger the start menu interface.

Thanks again for making this mod and catering to my previous request.

@donsingh donsingh changed the title [mod: empty taskbar click] update 1.7 no longer opens start menu if hidden [mod: empty taskbar click] update 1.7 no longer opens start menu if start button is hidden Nov 25, 2024
@m1lhaus
Copy link
Owner

m1lhaus commented Nov 25, 2024

Hi @donsingh, you are right. This never occured to me. Yes the button must be present on the taskbar since it uses Accessibility API to find and click the button. Hm, the easiest would be to send a Win keypress if the search for the button fails. Ideally there would be some undocumented WM_COMMAND message that would trigger the Start menu popup. Or other mechanism. I will first go with Win key and then try to look to projects like ExplorerPatcher how they control the Start menu. I remember they have an option that controls on which screen to open the menu.

@m1lhaus m1lhaus added the bug Something isn't working label Nov 25, 2024
@donsingh
Copy link
Author

the normal win keypress behavior will always open the start menu on the main monitor which leads us back to the original problem of 1.5.

m417z pushed a commit to ramensoftware/windhawk-mods that referenced this issue Dec 2, 2024
… from the taskbar (#1291)

Added fallback method to open Start menu when Start button was not found on the taskbar (e.g. was hidden via other Windhawk mod) - temporary hotfix for m1lhaus#21.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants