Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse proxying #4

Closed
klahaha opened this issue Sep 24, 2021 · 3 comments · May be fixed by #30
Closed

reverse proxying #4

klahaha opened this issue Sep 24, 2021 · 3 comments · May be fixed by #30
Labels
enhancement New feature or request

Comments

@klahaha
Copy link
Contributor

klahaha commented Sep 24, 2021

from here

Server.Proxy setting should enable/disable trusting of X-Forwarded-For headers
@klahaha klahaha mentioned this issue Sep 24, 2021
Merged
33 tasks
@m1k1o
Copy link
Owner

m1k1o commented Sep 26, 2021

Could be implemented as HTTP middleware.

@klahaha
Copy link
Contributor Author

klahaha commented Sep 26, 2021

i'm curious why. go-transcode doesn't filter by IP so why X-Forwarded-For ?

@m1k1o
Copy link
Owner

m1k1o commented Sep 26, 2021

Just for transparency and auditing, to have real user's IP in logs.

@m1k1o m1k1o added the enhancement New feature or request label Sep 26, 2021
@m1k1o m1k1o mentioned this issue Dec 10, 2021
Draft
@m1k1o m1k1o closed this as completed in edddccb Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V1 m1k1o/go-transcode
2 participants
@m1k1o @klahaha