Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample update to enable variable length subtitle #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

surajtripathy07
Copy link

@surajtripathy07 surajtripathy07 commented Dec 23, 2023

Adds ability to generate subtitle 1 word at a time

python auto_subtitle/cli.py <file path> -o <output>

should generate srt + overlayed video in the output dir..

Copy link

what-the-diff bot commented Dec 23, 2023

PR Summary

  • Refactor of cli.py File
    This pull request involves key changes made to the cli.py file, an important component of our software.

  • Updated Import Statements
    The import statement from .utils import filename, str2bool, write_srt was updated to from utils import filename, str2bool, write_srt. This change improves how our code accesses essential utility functions.

  • Advanced Function Parameters
    The transcribe function was called with additional arguments, namely initial_prompt="prompt" and word_timestamps=True. This modification enables more direct interaction with the transcription process and timestamps for each word in the text, making our output more detailed and informative.

  • Replace Function Call
    The write_srt function was replaced with the get_writer function along with the filename extension "srt" and options detailed in a dictionary. This transition enhances our ability to create subtitles in a more efficient and adaptive manner.

  • Enhanced User Feedback Messages
    Print statements have been added to display the output path and the message "Generating subtitles for {filename(path)}... This might take a while." These improvements enrich our user feedback system, enhancing the user experience by providing more detailed status updates during the subtitle generation process.

Copy link

sweep-ai bot commented Dec 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant