Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subtitle translation into other languages #103

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

adills
Copy link

@adills adills commented Oct 13, 2024

Great code! I only added the ability to use deep_translator to take your extracted subtitle and run it through a new function to translate the text into a different language.

I tested it with my personal video on a MacBook Pro M1 Max. I ran this to test:

pipenv run auto_subtitle ~/Downloads/PXL_20241007_234301920.mp4 --language_out es --model medium --output_dir ..

I hope you pull this for others to use.

Copy link

what-the-diff bot commented Oct 13, 2024

PR Summary

  • New Feature for Translating Subtitles
    The developer team has added a fantastic new feature in your command-line tool that allows users to translate the subtitles into their language of choice, improving accessibility. Supported languages include Spanish, with an easy-to-use command-line option (--language_out es).

  • Updated Setup and Requirements
    To ensure that this new translation feature works correctly, your team has also updated the necessary setup files (setup.py) and requirements (requirements.txt). This way, the program will automatically install deep_translator, a key software component that executes the translation functions.

  • Enhanced Core Functionality
    The part of the code responsible for processing subtitles has been changed to include the new translation function. This ensures that the added feature integrates smoothly with the existing application. This change contributes significantly to improving user experience, giving them content in the language they understand best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants