Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the method AbstractResource::set() return $this? #20

Open
ntd1712 opened this issue Jul 23, 2017 · 2 comments
Open

Could the method AbstractResource::set() return $this? #20

ntd1712 opened this issue Jul 23, 2017 · 2 comments

Comments

@ntd1712
Copy link

ntd1712 commented Jul 23, 2017

vendor/m1/vars/src/Resource/AbstractResource.php

/**
* Object oriented set access for the array
*
* @param string $key The key to set the value for
* @param string $value The value to set
*/
public function set($key, $value)
{
$this->internalSet($this->content, $key, $value);
}

@m1
Copy link
Owner

m1 commented Jul 23, 2017

It could, open a pull request and I'll pull it in :)

@peter279k
Copy link
Contributor

This issue is fixed and it should be closed now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants