Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record TimeZone in Geo data #39

Open
stephen-soltesz opened this issue May 7, 2020 · 3 comments
Open

Record TimeZone in Geo data #39

stephen-soltesz opened this issue May 7, 2020 · 3 comments

Comments

@stephen-soltesz
Copy link
Contributor

The geoip2.City struct includes a TimeZone field.

We should verify whether that value is actually present and save the timezone data with the location struct. This value is helpful for presenting results with local time-of-day.

If the TimeZone data is not in maxmind, then this becomes a tougher problem.

@pboothe
Copy link
Contributor

pboothe commented May 11, 2020

P1 if this data is in MaxMind, P2 or P3 if it's not there.

@pboothe
Copy link
Contributor

pboothe commented May 11, 2020

Server can do SiteInfo

@pboothe
Copy link
Contributor

pboothe commented May 11, 2020

TimeZone offset of the server might be useful as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants