Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example config and fix stat update #31

Merged
merged 16 commits into from
Mar 8, 2021

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Mar 5, 2021

This change includes two bug fixes.

  • bug1: the cached stat was not updated when a modification was discovered.
    • now, when files are updated, the new stat is cached.
  • bug2: prometheus collector registration failures cannot be recovered.
    • now, when a registration fails, the process exists, and the runtime must restart it.

These bugs prevented our deployment of the latest bqx version in M-Lab. These fixes should unblock that. And, with this change, we should be able to deploy query updates, have the changes be noticed, and automatically updated.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Mar 5, 2021

Pull Request Test Coverage Report for Build 100

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 84: 0.0%
Covered Lines: 260
Relevant Lines: 260

💛 - Coveralls

@stephen-soltesz
Copy link
Contributor Author

Unblocks: m-lab/prometheus-support#734
Fixes: #25

@stephen-soltesz stephen-soltesz requested a review from nkinkade March 6, 2021 01:09
Copy link

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 7 files at r1, 2 of 5 files at r2.
Reviewable status: 0 of 1 LGTMs obtained

@stephen-soltesz stephen-soltesz merged commit 15b9a45 into main Mar 8, 2021
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-fix-example branch August 12, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants