New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename .Count metrics to .Total #1041

Open

cristinaleonr opened this issue Dec 22, 2021 · 0 comments

Labels

Contributor

cristinaleonr commented Dec 22, 2021

According to Prometheus metric naming best practices, accumulating counts should end with the suffix Total https://prometheus.io/docs/practices/naming/.

A lot of the accumulating count metrics in etl (e.g., PanicCount, WorkerCount) have the Count suffix instead. Rename those.

autolabel bot added the review/triage label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment