From 7f69b3d1a71e06450acc85759799f24c1b20f807 Mon Sep 17 00:00:00 2001
From: Mikhail Dzianishchyts <mikhail.dzianishchyts@gmail.com>
Date: Tue, 8 Oct 2024 22:52:28 +0300
Subject: [PATCH] Update install, add caveats

---
 .github/workflows/release.yml | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 48422ab..acb5bba 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -36,16 +36,15 @@ jobs:
           version: ${{ github.ref_name }}
           depends_on: |
             "jupyterlab"
-            "java"
+            "expect" => :test
           target: jjava-${{ github.ref_name }}-kernelspec.zip
           install: |
-            libexec.install Dir["*"]
-            system "jupyter kernelspec install #{libexec} --sys-prefix --name=java "
+            libexec.install Dir["*.jar"]
+            config = buildpath/"kernel.json"
+            inreplace config, "{resource_dir}", libexec
+            system "jupyter kernelspec install #{buildpath} --config=#{config} --sys-prefix --name=java"
           test: |
-            jjava_version = Formula["jjava"].version
             jupyter = Formula["jupyterlab"].opt_bin/"jupyter"
-            ENV["JUPYTER_PATH"] = share/"jupyter"
-
             assert_match " java ", shell_output("#{jupyter} kernelspec list")
 
             (testpath/"console.exp").write <<~EOS
@@ -56,10 +55,13 @@ jobs:
               send "\u0004"
               expect -timeout 10 "exit"
               send "y\r"
-            EOS
+              EOS
             output = shell_output("expect -f console.exp")
-            assert_match "JJava kernel #{jjava_version}", output
+            assert_match "JJava kernel #{version}", output
             assert_match "Hello world!", output
+          caveats: |
+            Although JJava doesn't depend on java, it requires jre>=11 to run.
+            Make sure you have one in your PATH.
           update_readme_table: true
           github_token: ${{ secrets.HOMEBREW_REPO_ACCESS_TOKEN }}
           debug: ${{ runner.debug }}