Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query about Captured Pieces being updated #4

Open
zotz opened this issue Feb 21, 2023 · 1 comment
Open

Query about Captured Pieces being updated #4

zotz opened this issue Feb 21, 2023 · 1 comment

Comments

@zotz
Copy link

zotz commented Feb 21, 2023

I am trying to work with the codebase.

In board.py: we set: captured_pieces = { 'white': [], 'black': [] }

But we never seem to update this as pieces are captured.

Should this be updated somewhere in:

def _finish_move(self, piece, dest, p1, p2):

or elsewhere?

@lyudmil-mitev
Copy link
Owner

Yes, you are correct, the captured_pieces property was not used and _finish_move could be modified somewhere here in order to update the captured pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants