From d0c5af9acf5f4131f98142afe11007a102c42072 Mon Sep 17 00:00:00 2001
From: axel-kah <axel-kah@mailbox.org>
Date: Tue, 6 Aug 2024 18:04:57 +0200
Subject: [PATCH] Harmonizes naming pattern of pre-built binaries and unlocks
 latest permalink (#1464)

* ci: enables permalink for download of latest gh release assets

removes tag names to unlock latest-permalink

* ci: fix inconsistent gh release asset naming

changes macos and windows release assets to follow linux naming scheme: lychee-{cpu}-{platform}.{ext}

* ci: fix inconsistent asset naming of nightly builds

* ci: simplifies Dockerfiles by using latest permalink

* ci: adds comment to keep dependent files in sync
---
 .github/workflows/debug_build.yml |  4 ++--
 .github/workflows/release.yml     | 13 ++++++++++---
 Dockerfile-CI.Dockerfile          |  8 ++------
 Dockerfile-CI.alpine.Dockerfile   |  8 ++------
 4 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/.github/workflows/debug_build.yml b/.github/workflows/debug_build.yml
index bd0294d421..d307e25ea9 100644
--- a/.github/workflows/debug_build.yml
+++ b/.github/workflows/debug_build.yml
@@ -90,7 +90,7 @@ jobs:
         if: github.event_name == 'workflow_dispatch'
         uses: actions/upload-artifact@v4
         with:
-          name: lychee-${{ github.sha }}-macos-x86_64.dmg
+          name: lychee-${{ github.sha }}-x86_64-macos.dmg
           path: target/release/lychee.dmg
 
   windows:
@@ -120,5 +120,5 @@ jobs:
         if: github.event_name == 'workflow_dispatch'
         uses: actions/upload-artifact@v4
         with:
-          name: lychee-${{ github.sha }}-windows-x86_64.exe
+          name: lychee-${{ github.sha }}-x86_64-windows.exe
           path: target/release/lychee.exe
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index b04ec97c13..dd5cf038fa 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -1,3 +1,10 @@
+# CI pipeline for stable binaries
+# Keep in sync with:
+#   - .github/workflows/debug_build.yml
+#   - Dockerfile-CI.Dockerfile
+#   - Dockerfile-CI.alpine.Dockerfile
+#   - https://github.com/lycheeverse/lychee-action/blob/master/action.yml
+
 name: Release
 on:
   release:
@@ -82,7 +89,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          asset_name: lychee-${{needs.prepare.outputs.tag_name}}-${{ matrix.target }}.tar.gz
+          asset_name: lychee-${{ matrix.target }}.tar.gz
           asset_path: target/${{ matrix.target }}/release/lychee.tar.gz
           upload_url: ${{needs.prepare.outputs.upload_url}}
           asset_content_type: application/gzip
@@ -118,7 +125,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          asset_name: lychee-${{needs.prepare.outputs.tag_name}}-macos-x86_64.dmg
+          asset_name: lychee-x86_64-macos.dmg
           asset_path: target/release/lychee.dmg
           upload_url: ${{needs.prepare.outputs.upload_url}}
           asset_content_type: application/octet-stream
@@ -154,7 +161,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          asset_name: lychee-${{needs.prepare.outputs.tag_name}}-windows-x86_64.exe
+          asset_name: lychee-x86_64-windows.exe
           asset_path: target/release/lychee.exe
           upload_url: ${{needs.prepare.outputs.upload_url}}
           asset_content_type: application/octet-stream
diff --git a/Dockerfile-CI.Dockerfile b/Dockerfile-CI.Dockerfile
index 1f347475b2..6e87799354 100644
--- a/Dockerfile-CI.Dockerfile
+++ b/Dockerfile-CI.Dockerfile
@@ -9,14 +9,10 @@ RUN apt-get update \
     wget \
     && case $(dpkg --print-architecture) in \
       "amd64") \
-        wget -q -O - "$(wget -q -O- https://api.github.com/repos/lycheeverse/lychee/releases/latest \
-        | jq -r '.assets[].browser_download_url' \
-        | grep x86_64-unknown-linux-gnu)" | tar -xz lychee \
+        wget -q -O - https://github.com/lycheeverse/lychee/releases/latest/download/lychee-x86_64-unknown-linux-gnu.tar.gz | tar -xz lychee \
       ;; \
       "arm64") \
-        wget -q -O - "$(wget -q -O- https://api.github.com/repos/lycheeverse/lychee/releases/latest \
-        | jq -r '.assets[].browser_download_url' \
-        | grep  aarch64-unknown-linux-gnu)" | tar -xz lychee \
+        wget -q -O - https://github.com/lycheeverse/lychee/releases/latest/download/lychee-aarch64-unknown-linux-gnu.tar.gz | tar -xz lychee \
       ;; \
     esac \
     && chmod +x lychee
diff --git a/Dockerfile-CI.alpine.Dockerfile b/Dockerfile-CI.alpine.Dockerfile
index 95cf54f816..8394756ba9 100644
--- a/Dockerfile-CI.alpine.Dockerfile
+++ b/Dockerfile-CI.alpine.Dockerfile
@@ -5,14 +5,10 @@ RUN apk update \
     && apk add --no-cache ca-certificates jq wget \
     && case $(arch) in \
       "x86_64") \
-        wget -4 -q -O - "$(wget -4 -q -O- https://api.github.com/repos/lycheeverse/lychee/releases/latest \
-        | jq -r '.assets[].browser_download_url' \
-        | grep x86_64-unknown-linux-musl)" | tar -xz lychee \
+        wget -4 -q -O - https://github.com/lycheeverse/lychee/releases/latest/download/lychee-x86_64-unknown-linux-musl.tar.gz | tar -xz lychee \
       ;; \
       "aarch64") \
-        wget -4 -q -O - "$(wget -4 -q -O- https://api.github.com/repos/lycheeverse/lychee/releases/latest \
-        | jq -r '.assets[].browser_download_url' \
-        | grep arm-unknown-linux-musleabihf)" | tar -xz lychee \
+        wget -4 -q -O - https://github.com/lycheeverse/lychee/releases/latest/download/lychee-arm-unknown-linux-musleabihf.tar.gz | tar -xz lychee \
       ;; \
     esac \
     && chmod +x lychee