From 8ae8a0d360c55eb674a790593787d7ab31078491 Mon Sep 17 00:00:00 2001 From: Andrew Breckenridge Date: Fri, 12 Aug 2022 09:08:50 -0700 Subject: [PATCH] Package.swift: mark entire testTarget region as dev for rocket As @lukewakeford pointed out in https://github.com/Moya/Moya/commit/3206a0f4bd770befa6dcaa9463e9b308f749ca76#r81024749 our rocket integration for hiding dev dependencies (https://github.com/shibapm/Rocket#hide-dev-dependencies) was producing a malformed Package.swift for releases. this should fix the issue by instructing Rocket to comment out the entire testTarget, instead of just the `name:` line --- Changelog.md | 4 ++++ Package.swift | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/Changelog.md b/Changelog.md index 3ae2fa1fd..6c2a4b65b 100644 --- a/Changelog.md +++ b/Changelog.md @@ -1,5 +1,9 @@ # Next +### Fixed + +- Un-break Package.swift parsing when releasing through Rocket. [#2275](https://github.com/Moya/Moya/pull/2274) by [@AndrewSB](https://github.com/AndrewSB) + # [15.0.1] - 2022-08-11 ### Fixed diff --git a/Package.swift b/Package.swift index 54b95c19d..85d5af194 100644 --- a/Package.swift +++ b/Package.swift @@ -64,18 +64,18 @@ let package = Package( .product(name: "RxSwift", package: "RxSwift") ] ), - .testTarget( + .testTarget( // dev name: "MoyaTests", // dev - dependencies: [ - "Moya", - "CombineMoya", - "ReactiveMoya", - "RxMoya", - .product(name: "Quick", package: "Quick"), - .product(name: "Nimble", package: "Nimble"), - .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs") - ] - ) + dependencies: [ // dev + "Moya", // dev + "CombineMoya", // dev + "ReactiveMoya", // dev + "RxMoya", // dev + .product(name: "Quick", package: "Quick"), // dev + .product(name: "Nimble", package: "Nimble"), // dev + .product(name: "OHHTTPStubsSwift", package: "OHHTTPStubs") // dev + ] // dev + ) // dev ] )