Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples #183

Merged
merged 5 commits into from
Dec 22, 2024
Merged

Fix examples #183

merged 5 commits into from
Dec 22, 2024

Conversation

C47D
Copy link
Collaborator

@C47D C47D commented Nov 24, 2024 •
edited
Loading

Fix examples compilation (might not be rusty enough):

  • arc
  • animation
  • bar. I had to comment out lvgl::event_send to make this example compile and run.
  • button_click

Needs #177

@C47D C47D changed the title Fix arc example compilation Fix arc and animation examples Nov 24, 2024
@C47D C47D changed the title Fix arc and animation examples Fix examples Nov 24, 2024
@C47D C47D mentioned this pull request Nov 27, 2024
Open
@C47D C47D mentioned this pull request Dec 19, 2024
Open
6 tasks
@C47D
Copy link
Collaborator Author

C47D commented Dec 19, 2024

Can you help me reviewing this @AlixANNERAUD?

AlixANNERAUD
AlixANNERAUD reviewed Dec 19, 2024
View reviewed changes
Copy link

@AlixANNERAUD AlixANNERAUD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe the 1500 ms is too much.

examples/bar.rs Outdated Show resolved Hide resolved
examples/bar.rs Show resolved Hide resolved
examples/bar.rs Show resolved Hide resolved
@C47D C47D requested a review from AlixANNERAUD December 20, 2024 02:17
@C47D C47D merged commit 80fd2a7 into lvgl:master Dec 22, 2024
1 check passed
@C47D C47D deleted the fix_arc_example branch December 22, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlixANNERAUD AlixANNERAUD AlixANNERAUD approved these changes

@kisvegabor kisvegabor kisvegabor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@C47D @kisvegabor @AlixANNERAUD