RUSTSEC-2021-0145: Potential unaligned read

[github-actions]

Potential unaligned read

Details
Status	unsound
Package	atty
Version	0.2.14
URL	softprops/atty#50
Date	2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

• is-terminal
• std::io::IsTerminal nightly-only experimental

See advisory page for additional details.

[dalmoveras]

Hey! I'd love to work on this one.. I think should be an easy fix.
Already grepped by Atty on the code and found almost nothing:

lunatic$ git grep "atty"
Cargo.lock:name = "atty"
Cargo.lock: "atty",
Cargo.lock: "atty",
crates/lunatic-stdout-capture/src/lib.rs:    fn isatty(&self) -> bool {
deny.toml:    # atty advisory Windows - TBD

Let me know your thoughts

[bkolobara]

Thanks @dalmoveras. Would really appreciate a pull request if we can easily drop the lib.