Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if the host version does not match that of the client #37

Open
teymour-aldridge opened this issue Jul 6, 2022 · 1 comment

Comments

@teymour-aldridge
Copy link
Contributor

This should help to avoid problems (e.g. this one: teymour-aldridge/puck#52)

@bkolobara
Copy link
Contributor

This issue is a bit difficult to solve. For the version detection code to run, we need to run the Wasm module, but it can't be instantiated without satisfying imports (that are obviously incompatible between versions).

I can't think of a reliable way of embedding this information into the .wasm file that can be easily accessed by the runtime. We could maybe add a custom section? This would require pre-parsing the .wasm file and looking for the custom section, before it's parsed again by the engine and instantiated.

Hopefully, this will become less of a problem as breaking changes become less common in the future. And we only break the API in major versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants