Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove INTERNAL express.js spans #174

Open
mmanciop opened this issue May 4, 2023 · 0 comments
Open

Remove INTERNAL express.js spans #174

mmanciop opened this issue May 4, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mmanciop
Copy link
Contributor

mmanciop commented May 4, 2023

Given the fact that we use the opentelemetry-instrumentation-express alongside the @opentelemetry/instrumentation-http instrumentation, we create two spans per Express.js request: the SERVER span from @opentelemetry/instrumentation-http. and the INTERNAL one from opentelemetry-instrumentation-express. The upstream @opentelemetry/instrumentation-express does not provide access to the response object, so that is not an option either. We might have to write a bespoke instrumentation that adds an Express.js middleware to decorate the @opentelemetry/instrumentation-http span.

@mmanciop mmanciop added the enhancement New feature or request label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants