Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert physical_key UI bindings to logical_key #281

Open
lukexor opened this issue Jun 7, 2024 · 0 comments
Open

Convert physical_key UI bindings to logical_key #281

lukexor opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request tetanes

Comments

@lukexor
Copy link
Owner

lukexor commented Jun 7, 2024

Winit docs outline the differences pretty well: https://docs.rs/winit/latest/winit/event/struct.KeyEvent.html#structfield.physical_key

TetaNES allows fully customizing all keybindings, but it may be confusing to users with custom keyboard layouts to lookup the controls in the README, only to discover that the default key bindings don't match their layout.

Normally for games, physical_key can be useful like WASD for movement so the best path forward may be to support both and rely on physical_key for the default keyboard bindings for Player 1, and logical_key for all other bindings.

@lukexor lukexor added the enhancement New feature or request label Jun 7, 2024
@lukexor lukexor changed the title Convert all physical_key parsing to logical_key Convert physical_key UI bindings to logical_key Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tetanes
Projects
None yet
Development

No branches or pull requests

1 participant