Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import fails with Astro Build #955

Open
goldenratio opened this issue Dec 21, 2023 · 3 comments
Open

Import fails with Astro Build #955

goldenratio opened this issue Dec 21, 2023 · 3 comments

Comments

@goldenratio
Copy link

Describe the bug
Unable to use import state with Astro build https://astro.build/

To Reproduce
Steps to reproduce the behavior:

  import sortable from 'html5sortable';

Getting following error, run npm run build

error ts(7016): Could not find a declaration file for module 'html5sortable'. 'C:/Projects/foler_name/node_modules/html5sortable/dist/html5sortable.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/html5sortable` if it exists or add a new declaration (.d.ts) file containing `declare module 'html5sortable';`

32   import sortable from 'html5sortable';
                          ~~~~~~~~~~~~~~~


Expected behavior
import should work

@lukasoppermann
Copy link
Owner

This repo does not currently have typescript typings and will probably not get them soon.

This is not an astro issue, but rather a typescript one I think.

@clmnin
Copy link

clmnin commented Jun 12, 2024

@lukasoppermann why don't we have typescript typing support? The code is 97% typescript.

Genuine question, as I've never written a library and don't know how types are exported.

@lukasoppermann
Copy link
Owner

@clmnin I think the main issue is that this is not typed: https://github.com/lukasoppermann/html5sortable/blob/master/src/html5sortable.ts

97% is only because of the .ts ending. However this does not mean that all those files have correct type annotations.

Feel free to add a PR with typings for https://github.com/lukasoppermann/html5sortable/blob/master/src/html5sortable.ts to make this work better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants