Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag element to anywehere in sortable #880

Open
Daizygod opened this issue Apr 20, 2022 · 3 comments
Open

Drag element to anywehere in sortable #880

Daizygod opened this issue Apr 20, 2022 · 3 comments
Labels
feature New feature or enhancement help wanted

Comments

@Daizygod
Copy link

Describe the bug
I have more than one sortable, and when i drag elemnt to empty sortable,
placeholder visible and work only when i move mouse in element that have very small height, i fixed it just give <ul> style min-height: 100%. It works fine when sortable is empty, but when sortable have 1 element the situation repeats,
now i need move mouse to above or below element that already in list

I want that it work like when we drag first to empty (Work on all height size), can someone help me with this please?
I already read 3-5 pages issues and didn`t find some like this

Untitled Diagram drawio

I`m use SortableInput from kartik (infinity height, with scroll Y)but I think it's not that important

@lukasoppermann lukasoppermann added feature New feature or enhancement help wanted labels Aug 30, 2022
@lukasoppermann
Copy link
Owner

Hey, this makes sense. If you could send a PR I would love to merge it.

@Daizygod
Copy link
Author

Daizygod commented Sep 2, 2022

Hey, this makes sense. If you could send a PR I would love to merge it.

idk how to write code in this ptoject sry, i`m not have big expirience with it, at the moment I only can see the problem and text to you how i solved this

@ignazkevenaar
Copy link

Thanks for the wonderful graphs @Daizygod!
We also ran into this problem and traced it down to the !filter(element.children, options.items).length check at https://github.com/lukasoppermann/html5sortable/blob/master/src/html5sortable.ts#L637

@lukasoppermann can you fill me in on the importance of checking the target element is empty?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or enhancement help wanted
Projects
None yet
Development

No branches or pull requests

3 participants