Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jest@26 leads to 4 tests failing. #548

Open
lukasoppermann opened this issue Jul 4, 2020 · 5 comments
Open

Update to jest@26 leads to 4 tests failing. #548

lukasoppermann opened this issue Jul 4, 2020 · 5 comments
Labels
bug help wanted info needed More info needs to be provided to discuss/solve the issue

Comments

@lukasoppermann
Copy link
Owner

When updating the dependencies to jest@26 and ts-jest@26 4 tests in the __tests__/events/events.test.ts test file fail.

@kaffarell if you have time to look into this, it would be great. It is weird, but probably has to due with some change from jest.

@kaffarell
Copy link
Collaborator

kaffarell commented Jul 8, 2020

Sorry, I was not able to fix this.
What I have found out:

  • That the dataTransferObject now has a type (format) as first parameter
  • That we maybe have to add a type to the created customEvent (CustomEvent & {dataTransfer?: any})

But sadly none of these things have solved the issue 😭

@lukasoppermann lukasoppermann added the info needed More info needs to be provided to discuss/solve the issue label Jul 8, 2020
@lukasoppermann
Copy link
Owner Author

Hey @kaffarell thank you for looking into it! I guess we just have to keep trying to figure it out. Let's skip jest@26 for now and release without it.

@kaffarell kaffarell removed their assignment Aug 28, 2020
@lukasoppermann
Copy link
Owner Author

@atodorov do you think we should start a branch with to upgrade ts-jest & jest to @26? It will need quite some fixes though.

@atodorov
Copy link
Collaborator

A branch + a draft PR seem like a good first step, IDK what is breaking ATM and how much work that would be to adjust the tests.

@lukasoppermann
Copy link
Owner Author

Somehow it is mainly TS errors. Some tested parts return false instead of true now which is weird. Do you want to create a draft PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted info needed More info needs to be provided to discuss/solve the issue
Projects
None yet
Development

No branches or pull requests

3 participants