Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add problem matcher as alternate to comment #30

Open
nschonni opened this issue Dec 13, 2020 · 4 comments
Open

Add problem matcher as alternate to comment #30

nschonni opened this issue Dec 13, 2020 · 4 comments

Comments

@nschonni
Copy link

Registering a problem matcher like https://github.com/ludeeus/action-shellcheck/blob/master/.github/problem-matcher.json can let GitHub put inline comments on the Files tab of a PR

@luizm
Copy link
Owner

luizm commented Dec 30, 2020

Nice, I will take a look.. thank you @nschonni

@haraldh
Copy link

haraldh commented Apr 29, 2021

Any progress here?

@luizm
Copy link
Owner

luizm commented Jun 13, 2021

I took a look, and it works well to shellcheck, but to shfmt it doesn't.... because there are not line and column informations..

@nschonni
Copy link
Author

If there is no exact column/line number for the errors, I think you can use 1:1, and then it puts the comment at the top of the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants