draw_polygon does not fill in a square as I would expect

[AngledLuffa]

If I call draw_polygon with a square, it leaves the top row unfilled. Here is a small example:

>>> offset_simplex = numpy.array([[0, 4], [4, 4], [4, 0], [0, 0]])
>>> canvas = numpy.zeros((5, 5))
>>> mahotas.polygon.fill_polygon(offset_simplex, canvas)
>>> print canvas
[[ 0.  0.  0.  0.  0.]
 [ 1.  1.  1.  1.  1.]
 [ 1.  1.  1.  1.  1.]
 [ 1.  1.  1.  1.  1.]
 [ 1.  1.  1.  1.  1.]]

I would expect the top row to be filled. Certainly one cannot fix this by setting the coordinates to -1, as then nothing gets drawn.

Thanks!

[luispedro]

I see what you mean, but I'm not too sure what to do about it. The definition of a polygon that mahotas uses does not include those points, but the API certainly is confusing. I am a bit weary of just changing the code to fix this case as it's not too clear what other things it implies. I'll have to read up on it/think about it.

[AngledLuffa]

It's not clear in the documentation what definition is used or why it
wouldn't include the top. It's a little confusing that it would not
include the top, but does include the bottom, left, and right.

Thanks for looking!

On Wed, Apr 20, 2016 at 11:43 AM, Luis Pedro Coelho <
[email protected]> wrote:

I see what you mean, but I'm not too sure what to do about it. The
definition of a polygon that mahotas uses does not include those points,
but the API certainly is confusing. I am a bit weary of just changing the
code to fix this case as it's not too clear what other things it implies.
I'll have to read up on it/think about it.

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#73 (comment)