Port setup bash scripts to Crystal #875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #872
Closes #867
When a Lucky app is generated, a bunch of bash scripts are generated to help bootstrap the app by running CLI commands like
yarn installandshards install. The downside is that these are not portable over to Windows.In #867 I wrote PowerShell scripts to mimic the bash scripts, but that required me to first learn PowerShell, and then write a bunch of
{% if flag?(:windows) %}checks. This also creates a new level of complexity on maintaining the scripts.For this take, I just ported it all to Crystal. Even on Windows you'll still need to have Crystal installed, so this makes it a lot easier. Plus, there's a higher chance of a new dev picking up Crystal faster than learning Bash and/or PowerShell.