-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add out-of-the-box support for websockets #554
Comments
The WebSocket protocol is different from HTTP, but allows proxying in combination with an Having a look through class SomeAction < WebSocketAction
route do
send_from SomeActionChannel, data: 'foo'
end
end This assumes the following:
This feels more in line with how Lucky does other stuff than the Kemal example. @paulcsmith How do you feel about this? Interested in WS support at all? |
@citizen428 I think something like that sounds awesome. I think the best bet would be to have a third part shard until we figure out exactly what Channels should look like. Something like what https://github.com/cable-cr/cable. That way the community can try various things out and we can merge together the best ideas |
@paulcsmith Agreed re third party shard, especially given that their README states the following:
Let's try to rope in @fernandes and see if there's collaboration potential 🙂 |
hey @citizen428 thanks for pinging me yeah, absolutely, Like actioncable, just need one route to be "mounted" at the app, it comes with a handler, that can be used as inspiration If @jwoertink / @paulcsmith / @citizen428 wants to collaborate on |
@paulcsmith Maybe we could start with you creating the |
@citizen428 good idea. I'll level it |
I spoke too soon! I can't create a private repo. @citizen428 @fernandes would one of you be ok creating a repo and adding me to it? I'd be happy to collaborate on it with reviews or answering questions. I won't have much time to write code though :( |
added both you guys 😉 |
I'm in! Feel free to ping me or hit me up on Gitter! |
Thanks @paulcsmith @fernandes |
For anyone that comes looking for websocket support, you can dive in to the built in websocket support for now.
https://gitter.im/luckyframework/Lobby?at=5b5a51a61be9bb57bcc749bd
However, this is obviously something we should support out of the box with Lucky. I've never actually used websockets, so I don't know if they use HTTP methods or not, but looking at Kemal docs I would assume something like
The text was updated successfully, but these errors were encountered: