Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in dataset_readers.py #61

Open
yuzhongruicn opened this issue Jun 14, 2024 · 0 comments
Open

bug in dataset_readers.py #61

yuzhongruicn opened this issue Jun 14, 2024 · 0 comments

Comments

@yuzhongruicn
Copy link

Hi!
Thanks for the great work.
For those who want to try non-square image, there is a little bug in

fovy = focal2fov(fov2focal(fovx, image.size[1]), image.size[0])

which shoud be
fovy = focal2fov(fov2focal(fovx, image.size[0]), image.size[1])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant