Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate pushtip with github's pr #10

Open
4 tasks
lucasdemarchi opened this issue Jun 19, 2015 · 12 comments
Open
4 tasks

Integrate pushtip with github's pr #10

lucasdemarchi opened this issue Jun 19, 2015 · 12 comments

Comments

@lucasdemarchi
Copy link
Owner

pushtip was originally conceived for working with gitolite. Now that we need to survive the github era, it would be nice to have it better integrated with github's pull request.

Part of this work is already being done by #9. What more would be nice?

  • Automatically create pr for tip branches.
  • Close pr when new version is uploaded, pointing to the new version
  • Improve cleartip to clean both local and remote branches
  • "save" the coverletter/pull-request-description so you can start from it when writing a new one.

@cmarcelo @guludo anything else you have in mind?

@cmarcelo
Copy link
Collaborator

Wishlist: "save" the coverletter/pull-request-description so you can start from it when writing a new one.

@guludo
Copy link
Collaborator

guludo commented Jun 19, 2015

A note to @cmarcelo's suggestion: save it even if there's an error on creating a pull request so that you don't need to write all again on a second attempt. I remember struggling with that sort of problem when using git-send-branch.

@lucasdemarchi
Copy link
Owner Author

@guludo git send-branch saves everything under .git/.send-branch

@guludo
Copy link
Collaborator

guludo commented Jun 19, 2015

@lucasdemarchi so it didn't reloaded when I tried again...

@lucasdemarchi
Copy link
Owner Author

@guludo maybe because git-send-branch is very stupid... it doesn't reload anything. Ii just leaves the patches there in .git/.send_branch/ for you to use in case you want...

But if you call it again it erases the previous one heheh. Until now nobody worried to fix it because once I explain what is happening people just memorize how to workaround it :-\

@guludo
Copy link
Collaborator

guludo commented Jun 19, 2015

@lucasdemarchi hehe

Ok, just created an issue regarding this question with git-send-branch. :)

@lpereira
Copy link

lpereira commented Jul 7, 2015

Maybe creating an issue to group PR versions would be a good idea?

@lpereira
Copy link

lpereira commented Jul 7, 2015

Another thing that might help is automatically tagging issues/PRs with pending-review, review-ok, and please-merge. With this, it's possible to create a script that goes through open PRs/issues and merges them as we usually do (by rebasing, etc).

@lucasdemarchi
Copy link
Owner Author

I like the ideas. Are you going to implement this?

@lpereira
Copy link

lpereira commented Jul 7, 2015

I can give a try if nobody steps in.

@lpereira
Copy link

lpereira commented Jul 7, 2015

However -- this has to be well thought of. For instance, unless one can verify who added the please-merge tag, the commit can't actually be pushed.

@lucasdemarchi
Copy link
Owner Author

@lpereira please-merge is the one I don't really like...

@cmarcelo cmarcelo removed their assignment Feb 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants