From 184da013692da8247a44173a74926c9e8dd06a29 Mon Sep 17 00:00:00 2001 From: Lucas Caton Date: Sun, 21 Apr 2024 12:56:52 +1000 Subject: [PATCH] SQLite3 v2.x isn't yet working properly https://github.com/sparklemotion/sqlite3-ruby/issues/529 --- Appraisals | 11 ++++++++--- Gemfile.lock | 4 ++-- enumerate_it.gemspec | 2 +- gemfiles/rails_5.1.gemfile | 2 +- gemfiles/rails_5.2.gemfile | 2 +- gemfiles/rails_6.0.gemfile | 2 +- gemfiles/rails_6.1.gemfile | 6 +++--- gemfiles/rails_7.0.gemfile | 6 +++--- gemfiles/rails_7.1.gemfile | 6 +++--- 9 files changed, 23 insertions(+), 18 deletions(-) diff --git a/Appraisals b/Appraisals index 2c11a4c..465a5c1 100644 --- a/Appraisals +++ b/Appraisals @@ -15,10 +15,15 @@ rails_versions = JSON.parse(Net::HTTP.get(URI('https://rubygems.org/api/v1/versi if Gem::Version.new(rails_version) <= Gem::Version.new(5.0) gem 'sqlite3', '< 1.4' - elsif Gem::Version.new(RUBY_VERSION) < '3' - gem 'sqlite3', '< 2' else - gem 'sqlite3' + # v2.x isn't yet working. See: https://github.com/sparklemotion/sqlite3-ruby/issues/529 + gem 'sqlite3', '< 2' end + + # elsif Gem::Version.new(RUBY_VERSION) < '3' + # gem 'sqlite3', '< 2' + # else + # gem 'sqlite3' + # end end end diff --git a/Gemfile.lock b/Gemfile.lock index cff7a78..3b370a6 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -89,7 +89,7 @@ GEM rubocop-factory_bot (~> 2.22) ruby-progressbar (1.13.0) ruby2_keywords (0.0.5) - sqlite3 (2.0.1) + sqlite3 (1.7.3) mini_portile2 (~> 2.8.0) thor (1.2.2) tzinfo (2.0.6) @@ -110,7 +110,7 @@ DEPENDENCIES rubocop rubocop-rake rubocop-rspec - sqlite3 + sqlite3 (< 2) wwtd BUNDLED WITH diff --git a/enumerate_it.gemspec b/enumerate_it.gemspec index 74c30bc..22a96f4 100644 --- a/enumerate_it.gemspec +++ b/enumerate_it.gemspec @@ -30,6 +30,6 @@ Gem::Specification.new do |gem| gem.add_development_dependency 'rubocop' gem.add_development_dependency 'rubocop-rake' gem.add_development_dependency 'rubocop-rspec' - gem.add_development_dependency 'sqlite3' + gem.add_development_dependency 'sqlite3', '< 2' gem.add_development_dependency 'wwtd' end diff --git a/gemfiles/rails_5.1.gemfile b/gemfiles/rails_5.1.gemfile index 3bae5cb..d619ee6 100644 --- a/gemfiles/rails_5.1.gemfile +++ b/gemfiles/rails_5.1.gemfile @@ -4,6 +4,6 @@ source 'https://rubygems.org' gem 'activerecord', '~> 5.1.7' gem 'activesupport', '~> 5.1.7' -gem 'sqlite3' +gem 'sqlite3', '< 2' gemspec path: '../' diff --git a/gemfiles/rails_5.2.gemfile b/gemfiles/rails_5.2.gemfile index 05f7fb6..dc111f6 100644 --- a/gemfiles/rails_5.2.gemfile +++ b/gemfiles/rails_5.2.gemfile @@ -4,6 +4,6 @@ source 'https://rubygems.org' gem 'activerecord', '~> 5.2.8.1' gem 'activesupport', '~> 5.2.8.1' -gem 'sqlite3' +gem 'sqlite3', '< 2' gemspec path: '../' diff --git a/gemfiles/rails_6.0.gemfile b/gemfiles/rails_6.0.gemfile index 07b6361..a18ab8a 100644 --- a/gemfiles/rails_6.0.gemfile +++ b/gemfiles/rails_6.0.gemfile @@ -4,6 +4,6 @@ source 'https://rubygems.org' gem 'activerecord', '~> 6.0.6.1' gem 'activesupport', '~> 6.0.6.1' -gem 'sqlite3' +gem 'sqlite3', '< 2' gemspec path: '../' diff --git a/gemfiles/rails_6.1.gemfile b/gemfiles/rails_6.1.gemfile index 21a2bcb..8ccdedb 100644 --- a/gemfiles/rails_6.1.gemfile +++ b/gemfiles/rails_6.1.gemfile @@ -2,8 +2,8 @@ source 'https://rubygems.org' -gem 'activerecord', '~> 6.1.7.6' -gem 'activesupport', '~> 6.1.7.6' -gem 'sqlite3' +gem 'activerecord', '~> 6.1.7.7' +gem 'activesupport', '~> 6.1.7.7' +gem 'sqlite3', '< 2' gemspec path: '../' diff --git a/gemfiles/rails_7.0.gemfile b/gemfiles/rails_7.0.gemfile index 6d92660..a33a316 100644 --- a/gemfiles/rails_7.0.gemfile +++ b/gemfiles/rails_7.0.gemfile @@ -2,8 +2,8 @@ source 'https://rubygems.org' -gem 'activerecord', '~> 7.0.8' -gem 'activesupport', '~> 7.0.8' -gem 'sqlite3' +gem 'activerecord', '~> 7.0.8.1' +gem 'activesupport', '~> 7.0.8.1' +gem 'sqlite3', '< 2' gemspec path: '../' diff --git a/gemfiles/rails_7.1.gemfile b/gemfiles/rails_7.1.gemfile index 283f76b..efe656a 100644 --- a/gemfiles/rails_7.1.gemfile +++ b/gemfiles/rails_7.1.gemfile @@ -2,8 +2,8 @@ source 'https://rubygems.org' -gem 'activerecord', '~> 7.1.1' -gem 'activesupport', '~> 7.1.1' -gem 'sqlite3' +gem 'activerecord', '~> 7.1.3.2' +gem 'activesupport', '~> 7.1.3.2' +gem 'sqlite3', '< 2' gemspec path: '../'