Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal command names of tagpdf / kernel code #151

Open
u-fischer opened this issue Nov 13, 2024 · 1 comment
Open

Internal command names of tagpdf / kernel code #151

u-fischer opened this issue Nov 13, 2024 · 1 comment

Comments

@u-fischer
Copy link

luamplib has added tagging support. Thanks! The tagging looks fine as far as I can see after a short test.

But the code makes use of internal command names from the tagpdf module:

\tl_new:N \l__tag_luamplib_alt_tl
\tl_new:N \l__tag_luamplib_alt_dflt_tl
\tl_set:Nn\l__tag_luamplib_alt_dflt_tl {metapost~figure}
\tl_new:N \l__tag_luamplib_actual_tl
\tl_new:N \l__tag_luamplib_struct_tl
\tl_set:Nn\l__tag_luamplib_struct_tl {Figure}
\bool_new:N \l__tag_luamplib_usetext_bool
\bool_set_false:N \l__tag_luamplib_usetext_bool

These commands should be renamed to e.g. \l__luamplib_tag_alt_tl etc.

The code also uses some internal commands from the latex-lab code:

\l__tag_graphic_BBox_bool
\l__tag_graphic_bboxcorr_bool
\l__tag_graphic_bboxcorr_seq
\picture@tag@bbox@attribute

I quite understand that this is done because interfaces are missing. But please open an issue at https://github.com/latex3/tagging-project describing why you need these commands so that we can add proper interfaces.

@dohyunkim
Copy link
Contributor

dohyunkim commented Nov 14, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants