#112: Fixing deprecated error messages by upgrading to smarty4. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…marty4 php warnings. Updated documentation.
| @@ -218,7 +218,7 @@ | |||
|
|
|||
| # Smarty | |||
| if (!defined("SMARTY")) { | |||
| define("SMARTY", "/usr/share/php/smarty3/Smarty.class.php"); | |||
|
|
||
| .. _php-Smarty: https://pkgs.org/download/php-Smarty | ||
| .. _smarty4: https://pkgs.org/download/smarty4 |
There was a problem hiding this comment.
Here, you are in CentOS / RedHat section, and unfortunately, https://pkgs.org/download/smarty4 is only available for debian packages.
| @@ -126,7 +126,7 @@ | |||
| } | |||
|
|
|||
| # Lock | |||
| $pwdLockout = strtolower($ppolicy_entry[0]['pwdlockout'][0]) == "true" ? true : false; | |||
| $pwdLockout = strtolower(isset($ppolicy_entry[0]['pwdlockout'][0])) == "true" ? true : false; | |||
There was a problem hiding this comment.
No.
The value of $ppolicy_entry[0]['pwdlockout'][0] is TRUE (or FALSE, or nonexistent)
This value is the one of pwdLockout attribute in LDAP directory
Also, please don't mix multiple features/bug fixes in the same commit or pull request.
| @@ -82,6 +82,9 @@ | |||
| $smarty->setCacheDir($cache_dir); | |||
| $smarty->debugging = $smarty_debug; | |||
|
|
|||
| # Muting warnings due to PHP 8+ | |||
| $smarty->muteUndefinedOrNullWarnings(); | |||
|
|
|||
There was a problem hiding this comment.
Seems really interesting, but:
- the method is not available on smarty 3, making service-desk crashing
- on smarty4, we still have a lot of warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112