Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve tests in Ldap.php class #43

Open
davidcoutadeur opened this issue Sep 20, 2024 · 1 comment
Open

improve tests in Ldap.php class #43

davidcoutadeur opened this issue Sep 20, 2024 · 1 comment
Assignees
@davidcoutadeur
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@davidcoutadeur
Copy link

davidcoutadeur commented Sep 20, 2024 •
edited
Loading

Currently, we can't test functions that require to modify the arguments passed by reference.

Typically, the ldap_parse_result function, but maybe also other functions.

This prevents from doing complete tests, especially with paged searches test with multiple pages.

So the goal is to improve theses test functions:

  • test_search_with_page_size
  • test_modify_attributes_using_ppolicy

and determine if there is any other LDAP function modifying variables by reference.
@davidcoutadeur davidcoutadeur added the enhancement New feature or request label Sep 20, 2024
@davidcoutadeur davidcoutadeur self-assigned this Sep 20, 2024
@davidcoutadeur
Copy link
Author

See also bug opened on mockery project: mockery/mockery#1440

@coudot coudot added this to the Backlog milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidcoutadeur davidcoutadeur

Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@coudot @davidcoutadeur