Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial data class commit. #29

Merged
merged 8 commits into from
Feb 20, 2024
Merged

Initial data class commit. #29

merged 8 commits into from
Feb 20, 2024

Conversation

astronomerritt
Copy link
Collaborator

@astronomerritt astronomerritt commented Feb 13, 2024

Fixes #27.
This PR begins the basic data class structure for Adler.

Fixes #28.
Adds a command line script so Adler can be called on the command line. Changed the file structure a bit.

I have tested that this all works on the RSP. Yay!

@astronomerritt astronomerritt marked this pull request as draft February 13, 2024 16:23
@astronomerritt
Copy link
Collaborator Author

astronomerritt commented Feb 16, 2024

Going to pull this branch down to the RSP and test it before I request a review.

@astronomerritt astronomerritt marked this pull request as ready for review February 16, 2024 14:46
@astronomerritt astronomerritt changed the title (WIP) Initial data class commit. Initial data class commit. Feb 16, 2024
@mschwamb mschwamb self-requested a review February 17, 2024 19:49
Copy link
Collaborator

@mschwamb mschwamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the .DS_Store files and add .DS_Store to the .gitignore file - it's empty mac files and so we should not include them in the repository

Copy link
Collaborator

@jrob93 jrob93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I think the data structure has everything I need for now. I agree with Meg on gitignoring local .DS_Store files

@astronomerritt
Copy link
Collaborator Author

Good catch. I'd assumed .DS_Store was in the .gitignore. That should be it now.

@mschwamb
Copy link
Collaborator

Still need to remove the .DS_store that already got pushed before this PR. Those still exist in the PR

@astronomerritt
Copy link
Collaborator Author

Argh. Sorry. That should be all of them now.

@astronomerritt astronomerritt merged commit e506dce into main Feb 20, 2024
6 checks passed
@astronomerritt astronomerritt deleted the initial_data branch March 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants