Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

158 update adlerpy #159

Merged
merged 76 commits into from
Oct 8, 2024
Merged

158 update adlerpy #159

merged 76 commits into from
Oct 8, 2024

Conversation

jrob93
Copy link
Collaborator

@jrob93 jrob93 commented Aug 6, 2024 •
edited
Loading

Fixes #158. Also integrates changes from #119 which implement colour finding functions (currently PR #154).

I have added diaSourceId to the AdlerPlanetoid observations sql query, this is to make sure we have a unique identifier for each obs.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

jrob93 and others added 30 commits May 14, 2024 09:58
@jrob93
merge in plotting and outlier detection branches, to incorporate thes…
4af4b39 
…e into the demo

Merge branch '106-outlying-photometry-checker' into 119-adler-demo
@jrob93
initial changes to add outlier detection
d22b3b1
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
30cbc4a
@jrob93
update FitModel docs
fd053ef
@jrob93
adler cli updates
075994e
@jrob93
merge changes from #115
436cdeb
@jrob93
merge package name changes from main
1e71996 
Merge branch 'main' into 119-adler-demo
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
6e5bafd
@jrob93
option to remove sbpy model bounds
98ef9dc
@jrob93
added construct_from_SQL cli option, very basic
60b57a3
@jrob93
added construct_from_SQL cli option, very basic
886817c
@jrob93
basic outlier detection
a841c32
@jrob93
demo notebook
73b73ed
@jrob93
test data for demo
737e757
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
d38fd50
@jrob93
quick fix sql_fname CLI option
60dbd52
@pre-commit-ci-lite
[pre-commit.ci lite] apply automatic fixes
8738335
@jrob93
more unit tests
faba3ab
@jrob93
sql_filename cli test
d1b2eb0
@jrob93
add cli example to readme
15628ab
@jrob93
fix outpaths
87a1458
@jrob93
update sql_filename default
1d56f55
@jrob93
add x,y,z pos of observation
904d30d
@jrob93
include topocentric coords
80a6d35
@jrob93
add tperi to mpcorb query
211d9a0
@jrob93
add ecliptic coordinates to query
0392cf6
@jrob93
include MPCORB fullDesignation
1dcd88a
@jrob93
update fullDesignation unit test
dcf5088
@jrob93
fix fit covariance matrix
30420c6
@jrob93
add more tests
5950f22
@astronomerritt astronomerritt marked this pull request as ready for review October 1, 2024 14:20
@astronomerritt astronomerritt marked this pull request as draft October 1, 2024 14:20
@jrob93 jrob93 marked this pull request as ready for review October 7, 2024 11:45
@jrob93
Copy link
Collaborator Author

jrob93 commented Oct 7, 2024

@astronomerritt looks like I've fixed the unit test issue, I just saved the test dataframes with the diaSourceId column as int64. So this is ready to review, there is just that annoying linting issue which you said we could maybe just ignore?

@jrob93 jrob93 merged commit 69cac19 into main Oct 8, 2024
9 of 10 checks passed
@jrob93 jrob93 deleted the 158-update-adlerpy branch October 8, 2024 09:27
@jrob93 jrob93 mentioned this pull request Oct 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astronomerritt astronomerritt astronomerritt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update adler.py
2 participants
@jrob93 @astronomerritt