New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

136 Validating and testing new argument #141

Merged

jrob93 merged 1 commit into main from 136-test-and-validate

May 22, 2024

Collaborator

astronomerritt commented May 22, 2024 •

edited

Loading

Fixes #136 .

Added validation for the --sql_filename command-line argument that makes sure the filename exists.
Fixed a unit test that did not do what I thought it did.
Wrote a unit test to cover this.

Review Checklist for Source Code Changes

Does pip install still work?
Have you written a unit test for any new functions?
Do all the units tests run successfully?
Does adler run successfully on a test set of input files/databases?
Have you used black on the files you have updated to confirm python programming style guide enforcement?


          Validating and testing new argument

25b53f0

astronomerritt changed the title ~~Validating and testing new argument~~ 136 Validating and testing new argument

jrob93 approved these changes

View reviewed changes

jrob93 merged commit 71106d2 into main

10 checks passed

jrob93 deleted the 136-test-and-validate branch

May 22, 2024 13:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet