Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

106 outlying photometry checker #113

Merged
merged 5 commits into from
May 14, 2024
Merged

Conversation

jrob93
Copy link
Collaborator

@jrob93 jrob93 commented Apr 30, 2024

Fixes #106

I have added some simple and generic utility functions to detect outliers (e.g. outlying photometric wrt a phase curve model). I need to refine the example notebook and add unit tests.

Review Checklist for Source Code Changes

  • Does pip install still work?
  • Have you written a unit test for any new functions?
  • Do all the units tests run successfully?
  • Does adler run successfully on a test set of input files/databases?
  • Have you used black on the files you have updated to confirm python programming style guide enforcement?

@jrob93 jrob93 self-assigned this Apr 30, 2024
@jrob93 jrob93 linked an issue Apr 30, 2024 that may be closed by this pull request
@jrob93 jrob93 requested review from mschwamb and astronomerritt May 13, 2024 21:04
Merge branch 'main' into 106-outlying-photometry-checker
Copy link
Collaborator

@astronomerritt astronomerritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'd also like Meg to look at it.

@jrob93 jrob93 mentioned this pull request May 14, 2024
5 tasks
@mschwamb mschwamb merged commit 2894656 into main May 14, 2024
10 checks passed
@mschwamb mschwamb deleted the 106-outlying-photometry-checker branch May 14, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outlying photometry checker
3 participants