You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So far I have tried to write the PhaseCurve class such that it can handle model parameters with/without units. This is becasue sbpy expects units by default. As long as it doesn't make things tricky I would lean towards trying to use code in adler that is agnostic to variables with/without units. That being said, we will have to strip units from variables at some point anyway, in order to write values to a database.
The text was updated successfully, but these errors were encountered:
So the datacalasses I wrote don't care whether they're getting a Quantity or a float. It's just write-out that's problematic. I think the easiest way to handle this is to strip units before writing to a database - can also add a check to validate that the units are correct before they're removed.
How do we want to handle parameters that are of type "Quantity". I.e. objects that have a value and unit property https://docs.astropy.org/en/stable/units/
So far I have tried to write the PhaseCurve class such that it can handle model parameters with/without units. This is becasue sbpy expects units by default. As long as it doesn't make things tricky I would lean towards trying to use code in adler that is agnostic to variables with/without units. That being said, we will have to strip units from variables at some point anyway, in order to write values to a database.
The text was updated successfully, but these errors were encountered: