Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have an option to pass the TAPService object to AdlerPlanetoid? #135

Open
astronomerritt opened this issue May 16, 2024 · 0 comments
Assignees

Comments

@astronomerritt
Copy link
Collaborator

astronomerritt commented May 16, 2024

In the case where adler.py is iterating over several objects, we end up repeatedly recreating the pyvo.dal.tap.TAPService object. This isn't necessary, as it only needs to be set up once.

I am not sure if this could cause problems/slowdowns. I need to find out. If it's a problem, we can have an option to pass the pyvo.dal.tap.TAPService to AdlerPlanetoid.construct_from_RSP().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant