Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

order of observations #123

Open
jrob93 opened this issue May 14, 2024 · 1 comment
Open

order of observations #123

jrob93 opened this issue May 14, 2024 · 1 comment
Assignees

Comments

@jrob93
Copy link
Collaborator

jrob93 commented May 14, 2024

I've been testing AdlerPlanetoid on the RSP and I have noticed that the observations returned by construct_from_SQL and construct_from_RSP are not in time order. Also the two methods return observations in different orders. Not sure what they are ordered by (if anything).

This is probably an RSP/DP0.3 issue, but logging here to avoid any gotchas later on.

@astronomerritt
Copy link
Collaborator

Curious and moderately concerning. Thanks for bringing this up.

For consistency at the very least, I should implement something that sorts the retrieved data table on time of observation, before the dataclass attributes are populated. Then we can at least be sure everything is in date order.

@astronomerritt astronomerritt self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants