Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Premature closure of Dask Client #86

Open
davedavemckay opened this issue Dec 19, 2024 · 2 comments · Fixed by #90
Open

BUG: Premature closure of Dask Client #86

davedavemckay opened this issue Dec 19, 2024 · 2 comments · Fixed by #90
Assignees
Labels
bug Something isn't working

Comments

@davedavemckay
Copy link
Collaborator

BUG 🐛:

  • Dask Client closes when process_files() completes

INVESTIGATION 🕵️:

  • process_files() completes when all futures reach 'Completed' or 'Exception' status ('Exception' is a failsafe that hasn't ever been observed)
  • occurs with collated uploads (unknown if occurs with file upload)
  • futures reach 'Completed' when zip_and_upload returns
  • zip_and_upload returns when upload_and_callback returns or no files are found to zip (i.e., an empty folder is passed to zip_and_upload)
  • upload_and_callback returns when upload_to_bucket_collated returns result and result is written to log
  • upload_to_bucket_collated returns when swiftclient.Connection.put_object returns
  • swiftclient.Connection.put_object is a wrapper of swiftclient.client.post_object and returns a swiftclient.Connection._retry object
  • swiftclient.client.post_object seems to run in the background and update a response_dict on completion or fail after a given number of retries
    • introduction a while True that checks this response_dict may prevent premature closing of the Dask Client. 😅
@davedavemckay davedavemckay added the bug Something isn't working label Dec 19, 2024
@davedavemckay davedavemckay self-assigned this Dec 19, 2024
@davedavemckay
Copy link
Collaborator Author

Temporary fix with loop script.

@davedavemckay
Copy link
Collaborator Author

PR, but keep branch

@davedavemckay davedavemckay linked a pull request Dec 20, 2024 that will close this issue
@davedavemckay davedavemckay reopened this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant