From cc0e5b70866d15a8ca1df4a4f0ba9d48b955d940 Mon Sep 17 00:00:00 2001 From: Lucas Welscher Date: Tue, 18 Jul 2023 18:43:54 +0200 Subject: [PATCH] Fix too early truncate of feedbacks (#34) --- .../in/www1/bamboo/server/ServerNotificationTransport.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java b/src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java index 8c4c838..e75031d 100644 --- a/src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java +++ b/src/main/java/de/tum/in/www1/bamboo/server/ServerNotificationTransport.java @@ -88,7 +88,7 @@ public class ServerNotificationTransport implements NotificationTransport { private final ArtifactLinkManager artifactLinkManager = (ArtifactLinkManager) ContainerManager.getComponent("artifactLinkManager"); // Maximum length for the feedback text. The feedback will be truncated afterwards - private static final int FEEDBACK_DETAIL_TEXT_MAX_CHARACTERS = 5000; + private static final int FEEDBACK_MAX_LENGTH = 10_000; // Maximum number of lines of log per job. The last lines will be taken. private static final int JOB_LOG_MAX_LINES = 5000; @@ -510,8 +510,8 @@ private JSONObject createTestsResultsJSONObject(TestResults testResults, boolean JSONArray testCaseErrorDetails = new JSONArray(); for (TestCaseResultError testCaseResultError : testResults.getErrors()) { String errorMessageString = testCaseResultError.getContent(); - if (errorMessageString != null && errorMessageString.length() > FEEDBACK_DETAIL_TEXT_MAX_CHARACTERS) { - errorMessageString = errorMessageString.substring(0, FEEDBACK_DETAIL_TEXT_MAX_CHARACTERS); + if (errorMessageString != null && errorMessageString.length() > FEEDBACK_MAX_LENGTH) { + errorMessageString = errorMessageString.substring(0, FEEDBACK_MAX_LENGTH); } testCaseErrorDetails.put(errorMessageString); }