Fix for render problem. #9
Open
+103
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e translation differs for attribute and method texts. This fix solves the problem
FelixTJDietrich
requested changes
Oct 22, 2024
anian03
requested changes
Oct 22, 2024
fix for interface, abstract class type drawing issue
egenerse
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I tested with @kurunbelemir 's iPad. Resize and moving are working as expected. I was able to resize elements and move them on canvas and they were moving. These bugs are fixed.
FelixTJDietrich
requested changes
Nov 19, 2024
FelixTJDietrich
requested changes
Nov 25, 2024
| @@ -117,6 +117,43 @@ public class UMLElement: Codable, SelectableUMLItem { | |||
| self.children?.append(child) | |||
| } | |||
| } | |||
| //// NEWLY ADDED | |||
There was a problem hiding this comment.
What is this? Is this from cursor?
There was a problem hiding this comment.
No it was a note to myself, I forgot to delete.
There was a problem hiding this comment.
Okay let me k is once you have deleted those comments
| self.bounds?.height = newHeight | ||
| self.attributes?.removeAll { $0.id == attribute.id } | ||
| } | ||
| /////END OF NEWLY ADDED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When class diagram element move somewhere else translation differs for attribute and method texts. This fix solves the problem
Previous version
After fix
