Use the default model for the text Chain of Thought approach (#375)

ls1intum · Dec 9, 2024 · 5b031b4 · 5b031b4
1 parent 9968168
commit 5b031b4
Show file tree

Hide file tree

Showing 3 changed files with 82 additions and 85 deletions.
diff --git a/llm_core/llm_core/models/__init__.py b/llm_core/llm_core/models/__init__.py
@@ -19,8 +19,6 @@
     types.append(openai_config.OpenAIModelConfig)
     if default_model_name in openai_config.available_models:
         DefaultModelConfig = openai_config.OpenAIModelConfig
-    if "openai_gpt-4o-mini" in openai_config.available_models:        
-        MiniModelConfig = openai_config.OpenAIModelConfig(model_name="openai_gpt-4o-mini",max_tokens=3000, temperature=0,top_p=0.9,presence_penalty=0,frequency_penalty=0)
     if evaluation_model_name in openai_config.available_models:
         evaluation_model = openai_config.available_models[evaluation_model_name]
 except AttributeError:

diff --git a/modules/text/module_text_llm/module_text_llm/chain_of_thought_approach/__init__.py b/modules/text/module_text_llm/module_text_llm/chain_of_thought_approach/__init__.py
@@ -1,15 +1,14 @@
 from pydantic import BaseModel, Field
 from typing import Literal
-from llm_core.models import ModelConfigType, MiniModelConfig
+from llm_core.models import ModelConfigType, DefaultModelConfig
 
 from module_text_llm.approach_config import ApproachConfig
 from module_text_llm.chain_of_thought_approach.prompt_generate_feedback import CoTGenerateSuggestionsPrompt
 from module_text_llm.chain_of_thought_approach.prompt_thinking import ThinkingPrompt
 
 class ChainOfThoughtConfig(ApproachConfig):
-    # Defaults to the cheaper mini 4o model
     type: Literal['chain_of_thought'] = 'chain_of_thought'
-    model: ModelConfigType = Field(default=MiniModelConfig)  # type: ignore
+    model: ModelConfigType = Field(default=DefaultModelConfig)  # type: ignore
     thikning_prompt: ThinkingPrompt = Field(default=ThinkingPrompt())
     generate_suggestions_prompt: CoTGenerateSuggestionsPrompt = Field(default=CoTGenerateSuggestionsPrompt())