Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add note about data used in Artemis docs #7308

Merged
merged 8 commits into from
Oct 4, 2023

Conversation

jakubriegel
Copy link
Contributor

@jakubriegel jakubriegel commented Oct 3, 2023

Checklist

General

Motivation and Context

It is important to emphasise that Artemis documentation should provide nice experience to its readers and therefore use only real or well prepared data.

Description

Added a note about personas accounts to be use for preparing screenshots for docs.

Steps for Testing

Read the docs here.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

@jakubriegel jakubriegel requested a review from krusche October 3, 2023 14:58
@jakubriegel jakubriegel self-assigned this Oct 3, 2023
@jakubriegel jakubriegel changed the title Add note about data in RDT docs Development: Add note about data in RDT docs Oct 3, 2023
@jakubriegel jakubriegel marked this pull request as ready for review October 3, 2023 14:59
@jakubriegel jakubriegel requested a review from a team as a code owner October 3, 2023 14:59
@jakubriegel jakubriegel changed the title Development: Add note about data in RDT docs Development: Add note about data used in Artemis docs Oct 3, 2023
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice explanation; however, please consider removing the passive usage in the text

dearjasmina
dearjasmina previously approved these changes Oct 3, 2023
Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for addressing the feedback :)

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Co-authored-by: Benedikt Fein <[email protected]>
jakubriegel and others added 2 commits October 3, 2023 23:45
Co-authored-by: Benedikt Fein <[email protected]>
Co-authored-by: Benedikt Fein <[email protected]>
@krusche krusche added this to the 6.5.5 milestone Oct 4, 2023
Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice explanations! Looks good to me 👍

Copy link
Contributor

@laadvo laadvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New documentation looks good!

Copy link
Contributor

@dearjasmina dearjasmina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

@krusche krusche merged commit 36d5982 into develop Oct 4, 2023
6 checks passed
@krusche krusche deleted the screenshots-in-rtd-docs-data branch October 4, 2023 16:16
@krusche krusche modified the milestones: 6.5.5, 6.6.0 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants