-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exam mode
: Allow instructors to extend exam time
#7119
Conversation
src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java
Outdated
Show resolved
Hide resolved
…s in checklist component
…exam-mode/time-extension # Conflicts: # src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java # src/main/java/de/tum/in/www1/artemis/web/rest/StudentExamResource.java # src/main/webapp/app/exam/manage/exam-management.module.ts # src/main/webapp/i18n/de/exam.json # src/main/webapp/i18n/en/exam.json
...ain/java/de/tum/in/www1/artemis/service/messaging/DistributedInstanceMessageSendService.java
Outdated
Show resolved
Hide resolved
I'd like to see a few improvements to the working time edit dialog: First, we should have the possibility to use relative and absolut extension values (e.g. extending the working time by +10%). However, this can also get improved in a followup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally. working time extensions are corretly considered when calculating the new working time. The repository also gets locked at the correct time (depening on the individual working time).
src/main/java/de/tum/in/www1/artemis/service/exam/StudentExamService.java
Show resolved
Hide resolved
Let's do the absolute change in a new PR, if this is wanted. I've already discussed that with @krusche, for absolute changes people can use the The effect of the working time change is now shown in the dialog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the requested changes. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session. worked as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session on TS5, worked as described
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in testing session. Works well. One very minor thing: The timestamp shown on the intro page before starting the exam did not update, but the duration below did. Non-blocking for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested in testing session on ts5, worked as expected
We decided to add server tests in a follow-up PR |
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Changes affecting Programming Exercises
Motivation and Context
There are many problems that can occur during the exam. Many are hard to predict and even harder to fix in a timely manner. An example is an unexpected problem with artemis related servers.
Therefore, we need a feature to extend the working time.
Close #7045
Description
This PR adds a new button "Edit Exam Duration" to the exam summary page. When clicking, a dialog opens, which allows to edit the exam duration by adding time to it. After verifying with the exam name, and clicking "Change", the exam working time is updated.
Steps for Testing
Prerequisites:
Steps:
Edit Exam Duration
button to extend the working timeOutcome:
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots
Button disabled if close to submission
Update working time