Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exam mode: Allow instructors to extend exam time #7119

Merged
merged 48 commits into from
Sep 18, 2023

Conversation

krusche
Copy link
Member

@krusche krusche commented Aug 30, 2023

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I followed the coding and design guidelines.
  • I added multiple integration tests (Spring) related to the features (with a high test coverage).
  • I added pre-authorization annotations according to the guidelines and checked the course groups for all new REST Calls (security).
  • I documented the Java code using JavaDoc style.

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I followed the coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Changes affecting Programming Exercises

  • I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
  • I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

There are many problems that can occur during the exam. Many are hard to predict and even harder to fix in a timely manner. An example is an unexpected problem with artemis related servers.

Therefore, we need a feature to extend the working time.

Close #7045

Description

This PR adds a new button "Edit Exam Duration" to the exam summary page. When clicking, a dialog opens, which allows to edit the exam duration by adding time to it. After verifying with the exam name, and clicking "Change", the exam working time is updated.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 2 Students
  • 1 Exam w/ Programming exercises

Steps:

  1. Log in to Artemis
  2. Navigate to Course Administration
  3. Navigate to Exams
  4. Create an Exam
  5. Add a programming exercise to the exam
  6. Add students to the exam
  7. Start the exam
  8. While the exam is running, use the new Edit Exam Duration button to extend the working time
  9. Edit the time by which the exam deadline should be extended
  10. Enter the name of the exam
  11. Hit the "Change" Button

Outcome:

  • The working time update should be reflected in the exam summary view
  • The working time should update for all participating students
  • The programming exercise repositories should not lock at the original end time
  • The programming exercise repositories should lock at the updated end time

Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

Button disabled if close to submission

ezgif com-video-to-gif

Update working time

ezgif com-video-to-gif(1)

@krusche krusche requested a review from a team as a code owner August 30, 2023 20:18
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Aug 30, 2023
@krusche krusche marked this pull request as draft August 30, 2023 20:20
@aplr aplr self-requested a review September 7, 2023 08:50
@aplr aplr self-assigned this Sep 8, 2023
@krusche krusche added this to the 6.5.0 milestone Sep 8, 2023
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Sep 8, 2023
aplr added 6 commits September 9, 2023 13:40
…exam-mode/time-extension

# Conflicts:
#	src/main/java/de/tum/in/www1/artemis/web/rest/ExamResource.java
#	src/main/java/de/tum/in/www1/artemis/web/rest/StudentExamResource.java
#	src/main/webapp/app/exam/manage/exam-management.module.ts
#	src/main/webapp/i18n/de/exam.json
#	src/main/webapp/i18n/en/exam.json
@aplr aplr marked this pull request as ready for review September 9, 2023 14:50
@Strohgelaender
Copy link
Contributor

I'd like to see a few improvements to the working time edit dialog:

First, we should have the possibility to use relative and absolut extension values (e.g. extending the working time by +10%).
We should also directly see the effect of the working time change (new absolute working time, new end date) in this dialog.

However, this can also get improved in a followup.

Strohgelaender
Strohgelaender previously approved these changes Sep 15, 2023
Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally. working time extensions are corretly considered when calculating the new working time. The repository also gets locked at the correct time (depening on the individual working time).

@aplr
Copy link
Contributor

aplr commented Sep 16, 2023

I'd like to see a few improvements to the working time edit dialog:

First, we should have the possibility to use relative and absolut extension values (e.g. extending the working time by +10%). We should also directly see the effect of the working time change (new absolute working time, new end date) in this dialog.

However, this can also get improved in a followup.

Let's do the absolute change in a new PR, if this is wanted. I've already discussed that with @krusche, for absolute changes people can use the Edit functionality in the future. However, I'm open to discuss.

The effect of the working time change is now shown in the dialog.

Copy link
Member

@bassner bassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the requested changes. LGTM

@Strohgelaender Strohgelaender temporarily deployed to artemis-test5.artemis.cit.tum.de September 18, 2023 15:13 — with GitHub Actions Inactive
Copy link
Contributor

@laurenzfb laurenzfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session. worked as described

Copy link
Contributor

@basak-akan basak-akan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session on TS5, worked as described

Copy link
Contributor

@lennart-keller lennart-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in testing session. Works well. One very minor thing: The timestamp shown on the intro page before starting the exam did not update, but the duration below did. Non-blocking for this PR.

Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in testing session on ts5, worked as expected

@krusche
Copy link
Member Author

krusche commented Sep 18, 2023

We decided to add server tests in a follow-up PR

@krusche krusche merged commit a23c6be into develop Sep 18, 2023
47 of 49 checks passed
@krusche krusche deleted the feature/exam-mode/time-extension branch September 18, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) priority:high ready to merge server Pull requests that update Java code. (Added Automatically!) tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend exam deadline during conduction
8 participants