Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lectures: Fix Misalignment of "Download Complete PDF" Button #9798

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Lectures: Fix Misalignment of "Download Complete PDF" Button #9798

wants to merge 1 commit into from
+2 −2

Conversation

laxerhd
Copy link

@laxerhd laxerhd commented Nov 16, 2024 •
edited
Loading

Checklist

General

Client

  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The button was slightly misaligned with the text on the left.
Fixes #9795.

Description

I changed align-items-baseline to align-items-center and removed unwanted bottom margin with class="mb-0",
so not the text would get aligned but the boxes around them.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Course
  • 1 Lecture with a pdf lecture unit
  1. Log in to Artemis
  2. Navigate to the Course
  3. Navigate to the Lecture
  4. Take a look at the alignment

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Performance Tests

  • Test 1
  • Test 2

Test Coverage

Screenshots

Before:
image
After:
image

Summary by CodeRabbit

  • Style
    • Improved layout and presentation of lecture units in the course lecture details.
    • Adjusted header styling to remove bottom margin for a cleaner look.

@laxerhd laxerhd requested a review from a team as a code owner November 16, 2024 15:23
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Nov 16, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2024

Walkthrough

The pull request includes modifications to the HTML template of the course-lecture-details.component.html. The primary changes involve adjustments to the layout of lecture units, specifically altering the class for vertical alignment and updating the header class to remove bottom margin. No changes were made to the component's logic or control flow, and the functionality for displaying lecture details and managing attachments remains unchanged.

Changes

File Path Change Summary
src/main/webapp/app/overview/course-lectures/course-lecture-details.component.html Updated div class for lecture units from align-items-baseline to align-items-center and added mb-0 class to the header for removing bottom margin.

Assessment against linked issues

Objective Addressed Explanation
Align "Download Complete PDF" button with Lecture Units (9795) ✅

Possibly related PRs

Suggested labels

client, ready for review, small

Suggested reviewers

  • krusche
  • edkaya
  • iyannsch
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 32f6b56 and c97ab49.

📒 Files selected for processing (1)
  • src/main/webapp/app/overview/course-lectures/course-lecture-details.component.html (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/main/webapp/app/overview/course-lectures/course-lecture-details.component.html (1)

Pattern src/main/webapp/**/*.html: @if and @for are new and valid Angular syntax replacing *ngIf and *ngFor. They should always be used over the old style.

🔇 Additional comments (3)
src/main/webapp/app/overview/course-lectures/course-lecture-details.component.html (3)

55-55: LGTM! CSS changes effectively fix the button alignment.

The changes appropriately address the misalignment issue by:

  • Using align-items-center to vertically center the heading with the button
  • Removing bottom margin with mb-0 to ensure consistent spacing

Also applies to: 57-57

Line range hint 1-150: LGTM! Template follows Angular syntax guidelines.

The template correctly uses the new Angular syntax (@if, @for) throughout the file as required by the coding guidelines.

Line range hint 55-65: Verify the fix resolves the issue across all browsers.

The CSS changes appropriately address the misalignment issue described in #9795. Since the issue was reported across multiple browsers (Chrome, Safari, Edge, Firefox), it would be good to verify the fix in each browser.

✅ Verification successful

The alignment fix is robust and browser-independent

The changes use Bootstrap's align-items-center class which is consistently applied across the codebase without any browser-specific overrides. The solution:

  1. Uses flexbox alignment which has excellent cross-browser support
  2. Follows the same pattern used successfully in many other components in the codebase
  3. Doesn't require browser-specific CSS rules, making it a reliable fix
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any browser-specific CSS overrides or related issues
rg -g '*.css' -g '*.scss' -i 'align-items|vertical-align.*\b(chrome|safari|firefox|edge)\b'

Length of output: 22754

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

BBesrour
BBesrour approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@BBesrour BBesrour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

EneaGore
EneaGore approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@EneaGore EneaGore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@EneaGore EneaGore EneaGore approved these changes

@BBesrour BBesrour BBesrour approved these changes

@iyannsch iyannsch Awaiting requested review from iyannsch

Requested changes must be addressed to merge this pull request.

Assignees

@laxerhd laxerhd

Labels
client Pull requests that update TypeScript code. (Added Automatically!)
Projects
Artemis Development
Status: Ready For Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lectures: Misaligned "Download Complete PDF" Button
7 participants
@laxerhd @iyannsch @BBesrour @EneaGore @HawKhiem @sachmii @Fallthunderclap