Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAQ/Learning-Paths accessible despite deing disabled #9773

Closed
JanaNF opened this issue Nov 13, 2024 · 0 comments · Fixed by #9834
Closed

FAQ/Learning-Paths accessible despite deing disabled #9773

JanaNF opened this issue Nov 13, 2024 · 0 comments · Fixed by #9834
Assignees
Labels
atlas Pull requests that affect the corresponding module bug communication Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module

Comments

@JanaNF
Copy link

JanaNF commented Nov 13, 2024

Describe the bug

When an old message in a communication channel references the FAQ page, it is possible to access the page even if it has been disabled.

I talked with @krusche, and he said that for every feature we can disable (e.g. FAQ, learning paths), an error message/page (e.g. 404) should show up and you should not be able to access the pages. The REST calls should not return any data.

To Reproduce

  1. Enable the FAQ page
  2. Write a message in a public channel and reference/link to the FAQ page.
  3. Send the message
  4. Disable the FAQ page
  5. Go back to your message and click on the link
  6. You can now see the FAQ page

Expected behavior

If the FAQ page is disabled, it should not be accessible via any route or link.
The page should return a 404 or similar error indicating that the page is not available or that the route is not reachable.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

7.6.5

What browsers are you seeing the problem on?

Chrome

Additional context

This behavior is consistent with Artemis' default settings, as confirmed by @timin a discussion about the PR (PR #9566).
The same issue applies to other features, such as Learning Paths, where disabled routes remain accessible without an appropriate error message.

Relevant log output

No response

@JanaNF JanaNF added the bug label Nov 13, 2024
@github-actions github-actions bot added atlas Pull requests that affect the corresponding module communication Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module labels Nov 13, 2024
@cremertim cremertim linked a pull request Nov 20, 2024 that will close this issue
10 tasks
@MaximilianAnzinger MaximilianAnzinger moved this to Backlog in Atlas Dec 2, 2024
@cremertim cremertim self-assigned this Dec 5, 2024
@cremertim cremertim moved this from Todo to In Progress in Communication Webclient Dec 5, 2024
@cremertim cremertim linked a pull request Dec 5, 2024 that will close this issue
11 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Atlas Dec 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Communication Webclient Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atlas Pull requests that affect the corresponding module bug communication Pull requests that affect the corresponding module iris Pull requests that affect the corresponding module programming Pull requests that affect the corresponding module text Pull requests that affect the corresponding module
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants