Skip to content

Commit

Permalink
fix(app/metrics): irrevelant warnings for embed function (#1244)
Browse files Browse the repository at this point in the history
  • Loading branch information
lowlighter authored Sep 29, 2022
1 parent e80a5dc commit cb145da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion source/app/metrics/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export default async function metrics({login, q}, {graphql, rest, plugins, conf,
const warnings = []
if ((!Object.keys(Plugins).filter(key => q[key]).length) && (!parts.length))
warnings.push({warning: {message: "No plugin were selected"}})
const ineffective = Object.keys(q).filter(key => (key.includes(".")) && (key.split(".").at(0) !== "base") && (key.split(".").at(0) in Plugins)).filter(key => !q[key.split(".").at(0)])
const ineffective = Object.keys(q).filter(key => (key.includes(".")) && (key.split(".").at(0) !== "base") && (!(key in imports.metadata.plugins.base.inputs)) && (key.split(".").at(0) in Plugins)).filter(key => !q[key.split(".").at(0)])
warnings.push(...ineffective.map(key => ({warning: {message: `"${key}" has no effect because "${key.split(".").at(0)}: true" is not set`}})))
//Compute rendering
const {rendered} = await metrics({login, q}, {...arguments[1], convert: ["svg", "png", "jpeg"].includes(q["config.output"]) ? q["config.output"] : null, warnings}, arguments[2])
Expand Down

0 comments on commit cb145da

Please sign in to comment.