Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_dm] Support non-word bus access #4975

Closed
jrrk2 opened this issue Jan 26, 2021 · 8 comments
Closed

[rv_dm] Support non-word bus access #4975

jrrk2 opened this issue Jan 26, 2021 · 8 comments
Labels
Component:RTL IP:rv_dm Priority:P3 Priority: low Resolution:Duplicate Resolution tag for duplicate issues Type:Enhancement Feature requests, enhancements

Comments

@jrrk2
Copy link

jrrk2 commented Jan 26, 2021

It seems that JTAG access via system bus only supports word access on Ibex, can you confirm?

@tomeroberts
Copy link

Yes that looks to be the case. Not sure why it's hardwired that way, but there is currently a PR open to add support for other sizes in the debug module repo (here).

@jrrk2
Copy link
Author

jrrk2 commented Jan 26, 2021 via email

@imphil imphil changed the title Apparently dm_sba.sv only supports word level access, not 16-bit or 8-bit [rv_dm] Support non-word bus access Feb 3, 2021
@imphil imphil added Component:RTL Type:Enhancement Feature requests, enhancements labels Feb 3, 2021
@imphil
Copy link
Contributor

imphil commented Feb 25, 2021

Just a quick update here: Segger J-Link V6.94c+ (05 Feb 2021) now works if only word accesses are provided according to lowRISC/ibex#1218 (comment).

@msfschaffner
Copy link
Contributor

msfschaffner commented Feb 15, 2022

I have the feeling that this is not strictly required for the first revision, and would recommend to label this as a future enhancement that we can vendor in once the patch mentioned above has landed upstream. What do others think?

@msfschaffner msfschaffner added Priority:P3 Priority: low and removed Milestone:D2S labels Feb 15, 2022
@sriyerg
Copy link
Contributor

sriyerg commented Feb 15, 2022

Agreed, as long as it is clearly documented in the spec.

@rswarbrick
Copy link
Contributor

Sounds good to me.

@msfschaffner
Copy link
Contributor

Support for this has been merged upstream: pulp-platform/riscv-dbg#106.

However, there is a fix for a CDC bug outstanding here pulp-platform/riscv-dbg#123 and I would recommend to wait for that one to land before we vendor in anything.

@msfschaffner
Copy link
Contributor

Closing this issue since it is a duplicate.
Updates will be tracked here from now on: #11095.

@msfschaffner msfschaffner added the Resolution:Duplicate Resolution tag for duplicate issues label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:RTL IP:rv_dm Priority:P3 Priority: low Resolution:Duplicate Resolution tag for duplicate issues Type:Enhancement Feature requests, enhancements
Projects
None yet
Development

No branches or pull requests

10 participants