Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruments are missing (GAX V2) #21

Open
loveemu opened this issue Jun 8, 2021 · 0 comments
Open

Instruments are missing (GAX V2) #21

loveemu opened this issue Jun 8, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@loveemu
Copy link
Owner

loveemu commented Jun 8, 2021

  • Game title: Disney's Treasure Planet
  • Song: MontressorPlatform.minigsf (and others as well?)
  • Commit hash: 66c9f16

https://www.youtube.com/watch?v=A0f8yZ6K_cY

As an example, you can tell starting by 0:14 in gameending/credits that instruments are not playing.

FYI: I manually ripped the soundtrack to inspect the details of the issue.

Cause and solution

This problem can be solved by setting a reference to a different sample set than the song data in the Gax2Params structure (offset 0x2c). The address of the sample set is 0x80E7F84. I had assumed that this sample set was only used for FX and did not affect the music playback, but apparently that was a false assumption.

Gaxtapper does not yet implement a scanner for this kind of data. Therefore, more coding is needed to solve the problem.

@loveemu loveemu added the bug Something isn't working label Jun 8, 2021
@loveemu loveemu self-assigned this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant